feat(middleware): add a hook to inspect HTTP responses - #3074

gator-agent

PR Review Status

This implementation is project-valid under accepted issue #2691, and the initial full-diff review found one blocking fail-open correctness issue. The response middleware, relay coverage, and Fern documentation otherwise align with the intended response-hook path.

Action required: update the response fallback so valid but middleware-unrepresentable responses obey each selected stage's on_error policy, then push a new head for a delta review.

Blocking findings:

• GATOR-150ae32b-01: valid responses can become unconditional 502 failures even when every selected response stage is fail_open.

Carried findings:

• None

Non-blocking suggestions:

• None

gator-agent

Re-check After Author Update

Thanks @pimlock. I checked your note that the staging fix was extracted to #3262 and reviewed the latest refactor delta in critical-only mode. PR #3262 contains the targeted Cargo target_directory lookup, and this delta introduces no new Critical findings. However, #3074 still documents and exercises CARGO_TARGET_DIR while its current merge tree stages from the hard-coded repository target/ directory, so the carried obligation remains until #3262 lands.

Action required: merge #3262 before #3074, or bring its staging fix into #3074, then update this branch so Gator can confirm the effective merge tree.

Blocking findings:

• No new Critical findings.

Carried findings:

• GATOR-c6022c32-01: unresolved in #3074's current merge tree; the fix is pending in #3262.
• GATOR-150ae32b-01: remains resolved.

gator-agent

Maintainer Approval Needed

Thanks @pimlock. I verified that the staging fix you extracted to #3262 has merged and is present in this head's effective tree: staging now resolves Cargo's effective target_directory. I also reviewed the two new middleware commits in critical-only mode; they introduce no new Critical findings.

Review: no blocking findings remain. GATOR-150ae32b-01 remains resolved, and GATOR-c6022c32-01 is resolved by merged #3262.

Human maintainer approval is now required.

gator-agent

PR Review Status

The documentation-only delta after the approval handoff removes hard wrapping without changing the published middleware contract. The critical-only review found no new Critical defects. The carried staging dependency is satisfied by merged #3262, and both prior Gator findings remain resolved.

Blocking findings:

• No blocking findings remain

Carried findings:

• GATOR-150ae32b-01: remains resolved; this prose-only delta does not affect the fail-open response behavior.
• GATOR-c6022c32-01: remains resolved by merged #3262, whose Cargo target-directory staging fix is present in the effective tree.